Error if an Entity is overloading a getter method #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| var f = entityProcessor.getMethodProcessor().process(null, FieldCoordinates.coordinates(typeName, name.get()), meta, method); | ||
| if (name.isEmpty()) return false; | ||
| return validMethods.put(name.get(), method) != null; |
There was a problem hiding this comment.
for filters like this. To reduce cognitive load they should all be pure functions. Don't mind it reading from out of scope but modifying makes reasoning hard
| var method = type.getMethod(field.getName()); | ||
| if (method.isAnnotationPresent(GraphQLIgnore.class)) return false; | ||
| var name = EntityUtil.getName(field.getName(), field, method); | ||
| return validMethods.put(name, method) != null; |
There was a problem hiding this comment.
Same as the above filter, it modifies the state outside its scope
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found out that if you were overloading a method the Schema gen would be non-determinsitc and could be any of your definitions. see House.java for example.
Have changed generation so now we check that all methods that will be turned to fields are unique within an entity, otherwise throw an exception.